fix Float32/Float16 power for giant integer exponents #57829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The diff here is kind of awful since I rearranged the methods to be in an actually sensible order. I can move them back to the original order if that would be preferred. |
|
I would appreciate either two separate PRs or two separate commits within the PR. |
oscardssmith
force-pushed
the
os/Float32totypemaxInt
branch
from
3ec4f83 to
7ed3d60
Compare
|
updated with fixed order. |
|
turns out there were a few glaring errors (but I think they are all fixed now). Lets see if CI agrees) |
Co-authored-by: Lilith Orion Hafner <lilithhafner@gmail.com>
oscardssmith
force-pushed
the
os/Float32totypemaxInt
branch
from
8f04cea to
73607de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternative to #57488