-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main: run respec
workflow only on changes to relevant files
#4495
base: main
Are you sure you want to change the base?
Conversation
respec.yaml
only on changes to relevant filesrespec
workflow only on changes to relevant files
@ralfhandl Would you link to one of these spurious spec publishing PRs? |
@duncanbeevers For example #4412. Opened three weeks ago, still unmerged because it did not get a second approval, refreshed several times due to merges into Now I'll wait for someone else to approve first and hope that I can approve second and immediately merge before the next refresh dismisses the first review. |
Unfortunately there are seemingly random flip-flop changes that have no visible effect that I can spot. Some seem to be related to the time-of-day on the server and dark mode. Another is whether the table of contents is inlined, which should only depend on the width of the browser window, and that width should be deterministic for the head-less puppeteer browser. |
@duncanbeevers Thanks for asking, it got me thinking: we anyway tweak the respec output to avoid breaking Google Analytics, so why not also filter out the known non-deterministic things. |
I see there are changes in here to make the output more stable. I think those changes should be landed first / independently. |
@@ -58,9 +58,11 @@ for specification in $specifications; do | |||
|
|||
node scripts/md2html/md2html.js --maintainers $maintainers $specification "$allVersions" > $tempfile | |||
npx respec --no-sandbox --use-local --src $tempfile --out $tempfile2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using the TZ
env var while running npx respec
to ensure more-consistent output, regardless of where the workflow / script is run.
TZ=UTC npx respec …
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting idea. Did you test whether it has the desired effect for the fluctuating darkmode
?
@duncanbeevers I think these are fine in one PR:
|
Getting tired of re-reviewing spec publishing PRs on every change to unrelated files on
main
:Tick one of the following options: