-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increasing the maxLength property for a String field is considered a breaking change while Decreasing it is considered as Backward compatible. #461
Comments
@Hazel-John Thanks for reporting this! We probably have to consider whether the What do you think?
|
|
@edgar-philipp Is this really a breaking change? |
@joschi For e.g.,
Kindly let us know your views on the above statement. |
While testing out this tool, we've noticed that
increasing the maxLength
property for a String field would returnAPI changes broke backward compatibility
whiledecreasing the maxLength property
for a String field would return aAPI changes are backward compatible
.Shouldn’t it be the other way round? i.e.,
Increasing the maxLength property for a String field should return API changes are backward compatible and
Decreasing the maxLength property for a String field should return API changes broke backward compatibility?
If the current behaviour is the expected behaviour we would like to understand the reasoning behind it.
Here are the snippets of the json files used for the comparison in the following 2 scenarios:
Scenario -1 : Increasing the maxLength property for a String field
oldSpec.json
newSpec.json
Result:
Scenario -2 : Decreasing the maxLength property for a String field
oldSpec.json
newSpec.json
Result:
Thank You
The text was updated successfully, but these errors were encountered: