Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] Fix for allOf multi model with only metadata fields #20892

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ranger-ross
Copy link
Contributor

This PR fixes one of the bugs reported in #20500.

The following schema will generate models with a Vec with the generic parameter causing compiler errors.

components:
  schemas:
    Order:
      type: object
      properties:
        id:
          type: integer
          format: int64
        foo:
          allOf:
            - $ref: '#/components/schemas/existing_tags_array'
            - description: 'this is foo'

Because the second parameter simply metadata that is not important to code generation we can simply ignore it.
NOTE: This fix does not add full support for allOf with multiple non-model types.

PR checklist
  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc: @frol @farcaller @richardwhiuk @paladinzh @jacob-pro
cc @OpenAPITools/generator-core-team @wing328 since this fix may change the behavior of other clients

schema.get$anchor() != null ||
schema.getContentSchema() != null;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR

would it be better to put this method in the model util class as static method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Generated rust DigitalOcean API not compiling due to several errors
2 participants