Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix closures #267

Open
drernie opened this issue Mar 2, 2025 · 4 comments · May be fixed by #268
Open

fix closures #267

drernie opened this issue Mar 2, 2025 · 4 comments · May be fixed by #268

Comments

@drernie
Copy link
Contributor

drernie commented Mar 2, 2025

; { _ }
# # 

Somehow it does not close until a second '}'

Also: hide sidebar of hcweb on mobile?

@drernie drernie linked a pull request Mar 2, 2025 that will close this issue
@drernie drernie linked a pull request Mar 2, 2025 that will close this issue
@drernie
Copy link
Contributor Author

drernie commented Mar 2, 2025

Doh! We never actually escaped variables, or tested in parser.

Need to add a 'quote' special form, for this and Schema.
When evaluated, return the Name instead of trying to lookup a value.
Question is: how do we know the Context?

@drernie
Copy link
Contributor Author

drernie commented Mar 2, 2025

FrameSymbol.called_by:57
we evaluate '_' in context of the level 1 LexPipe.
That PIpe should know we are in a lazy (quoted) regime.

@drernie drernie changed the title fix underbar fix closures Mar 11, 2025
@drernie
Copy link
Contributor Author

drernie commented Mar 11, 2025

    return new FrameName(this.data, context.meta);

Gives (differnet) error:

evaluate ... grouping ... returns closure with underbar {_} => https://jsr.io/@std/testing/1.0.9/_test_suite.ts:393:15
error: TypeError: performer.perform is not a function
    return performer.perform(actions);

@drernie
Copy link
Contributor Author

drernie commented Mar 11, 2025

Actually: what do we do with non-symbols? Shouldn't we do that with quote symbols? Fallback to apply?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant