Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support private mirrors #1240

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marco-ippolito
Copy link

Fixes: #1150
Fixes: #730

@marco-ippolito
Copy link
Author

the failures dont seem related to this change are they?

@aparnajyothi-y
Copy link
Contributor

Hello @marco-ippolito, Thank you for your pull request! We are currently reviewing it. To resolve the check failures, could you please rebase your branch with the main branch and push the changes.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@marco-ippolito
Copy link
Author

@aparnajyothi-y thanks, rebased

@aparnajyothi-y
Copy link
Contributor

Hello marco-ippolito,
The fallback log message could be clarified to reduce potential confusion between falling back directly from Node and falling back to downloading from the Node mirror URL. Currently, it states: "Falling back to download directly from Node" for both scenarios.
A slight adjustment could provide clearer context in the logs. Please feel free to reach out if you have any concerns.
Screenshot 2025-03-27 at 6 46 41 PM

@marco-ippolito
Copy link
Author

@aparnajyothi-y change the message to Not found in manifest. Falling back to download directly from 'your-mirror'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add input for NodeJS distribution url Support node.js mirror like nvm
2 participants