Add parameters support to batches.list and update README to include /v1/embeddings Batches support #492
+25
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marckohlbrugge
force-pushed
the
main
branch
3 times, most recently
from
c39190f to
b1fc5b9
Compare
|
Thanks @marckohlbrugge ! |
|
Released in v7.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #490
I added a new test that creates a batch first, so we can test the
afterparameter. Without an existing batch, it would return an error.Edit: Looks like there's some Rubocop linting issues. I wasn't able to get Rubocop running so perhaps @alexrudall you can take care of these as they seem auto-fixable.
Edit 2: Okay, I fixed the Rubocop linting issues. Only thing left to make the test pass is to record a new VCR cassette. I'm not comfortable getting my company details in there, so can you do it @alexrudall? I already checked locally, and the test pass with a valid API key.