Skip to content

Remove magic numbers from Tone() examples #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion examples/02.Digital/toneKeyboard/toneKeyboard.ino
Original file line number Diff line number Diff line change
@@ -19,6 +19,8 @@

#include "pitches.h"

int buzzerPin = 8;

const int threshold = 10; // minimum reading of the sensors that generates a note

// notes to play, corresponding to the 3 sensors:
@@ -37,7 +39,7 @@ void loop() {
// if the sensor is pressed hard enough:
if (sensorReading > threshold) {
// play the note corresponding to this sensor:
tone(8, notes[thisSensor], 20);
tone(buzzerPin, notes[thisSensor], 20);
}
}
}
6 changes: 4 additions & 2 deletions examples/02.Digital/toneMelody/toneMelody.ino
Original file line number Diff line number Diff line change
@@ -17,6 +17,8 @@

#include "pitches.h"

int buzzerPin = 8;

// notes in the melody:
int melody[] = {
NOTE_C4, NOTE_G3, NOTE_G3, NOTE_A3, NOTE_G3, 0, NOTE_B3, NOTE_C4
@@ -34,14 +36,14 @@ void setup() {
// to calculate the note duration, take one second divided by the note type.
//e.g. quarter note = 1000 / 4, eighth note = 1000/8, etc.
int noteDuration = 1000 / noteDurations[thisNote];
tone(8, melody[thisNote], noteDuration);
tone(buzzerPin, melody[thisNote], noteDuration);

// to distinguish the notes, set a minimum time between them.
// the note's duration + 30% seems to work well:
int pauseBetweenNotes = noteDuration * 1.30;
delay(pauseBetweenNotes);
// stop the tone playing:
noTone(8);
noTone(buzzerPin);
}
}

16 changes: 10 additions & 6 deletions examples/02.Digital/toneMultiple/toneMultiple.ino
Original file line number Diff line number Diff line change
@@ -15,25 +15,29 @@
https://www.arduino.cc/en/Tutorial/BuiltInExamples/toneMultiple
*/

int buzzerOnePin = 6;
int buzzerTwoPin = 7;
int buzzerThreePin = 8;

void setup() {
}

void loop() {
// turn off tone function for pin 8:
noTone(8);
noTone(buzzerThreePin);
// play a note on pin 6 for 200 ms:
tone(6, 440, 200);
tone(buzzerOnePin, 440, 200);
delay(200);

// turn off tone function for pin 6:
noTone(6);
noTone(buzzerOnePin);
// play a note on pin 7 for 500 ms:
tone(7, 494, 500);
tone(buzzerTwoPin, 494, 500);
delay(500);

// turn off tone function for pin 7:
noTone(7);
noTone(buzzerTwoPin);
// play a note on pin 8 for 300 ms:
tone(8, 523, 300);
tone(buzzerThreePin, 523, 300);
delay(300);
}
4 changes: 3 additions & 1 deletion examples/02.Digital/tonePitchFollower/tonePitchFollower.ino
Original file line number Diff line number Diff line change
@@ -17,6 +17,8 @@
https://www.arduino.cc/en/Tutorial/BuiltInExamples/tonePitchFollower
*/

int buzzerPin = 9;

void setup() {
// initialize serial communications (for debugging only):
Serial.begin(9600);
@@ -34,6 +36,6 @@ void loop() {
int thisPitch = map(sensorReading, 400, 1000, 120, 1500);

// play the pitch:
tone(9, thisPitch, 10);
tone(buzzerPin, thisPitch, 10);
delay(1); // delay in between reads for stability
}