Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix to log model checkpoints as artifacts #1428

Closed
wants to merge 2 commits into from
Closed

Bug fix to log model checkpoints as artifacts #1428

wants to merge 2 commits into from
+11 −6

Conversation

manangoel99
Copy link

@manangoel99 manangoel99 commented Aug 31, 2022 •
edited
Loading

Description

This PR fixes the WandbLogger.log_artifact method which was initially overwriting the provided artifact argument.
Moreover, in order to save models as artifacts, it adds the runner.log_artifact call to the CheckpointCallback.

Related Issue

Fixes #1427

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Checklist

  • Have you updated tests for the new functionality?
  • Have you added your new classes/functions to the docs?
  • Have you updated the CHANGELOG?
  • Have you run colab minimal CI/CD with latest requirements? Please attach the notebook link.
  • Have you run colab minimal CI/CD with minimal requirements? Please attach the notebook link.
  • Have you checked XLA integration? Please attach the notebook link.
  • Have you checked distributed XLA integration? Please attach the notebook link.

Sorry, something went wrong.

@manangoel99
- Fixed bug in WandbLogger.log_artifact for overwriting artifact ar…
93d90fe 
…gument

- Added `runner.log_artifact` call in CheckpointCallback
@manangoel99
CHANG
d7d75dd
@CLAassistant
Copy link

CLAassistant commented Aug 31, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@stale
Copy link

stale bot commented Oct 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 30, 2022
@stale stale bot closed this Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scitator Scitator

@bagxi bagxi

Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to enforce WandbLogger::log_artifact to be invoked?
2 participants
@manangoel99 @CLAassistant