Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo fixes for writingjavadocchecks.html #5

Closed
wants to merge 2 commits into from
Closed

Typo fixes for writingjavadocchecks.html #5

wants to merge 2 commits into from

Conversation

Glusk
Copy link

@Glusk Glusk commented Jan 25, 2019

No description provided.

@Glusk Glusk changed the title Fixed grammar error. Typo fixes for writingjavadocchecks.html Jan 25, 2019
@rnveach
Copy link

rnveach commented Jan 25, 2019

@Glusk2 Changes look good unfortunately you have made the changes in the wrong repo.
This repo is the output of our site build from the main repo. You must make the changes in the checkstyle repo and not here, otherwise they will be overlayed with the next release.

Please make changes to https://github.com/checkstyle/checkstyle/blob/master/src/xdocs/writingjavadocchecks.xml.vm

When you start the PR there, please keep it as 1 commit and start the commit message with doc: .

@rnveach rnveach closed this Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Glusk @rnveach