OAuthProvider::getRequestTarget() enforce https instead of throwing

Author: codemasher

src/Core/OAuthProvider.php

@@ -311,7 +311,7 @@ protected function getRequestBody(StreamInterface|array|string $body, RequestInt
 	/**
 	 * Determine the request target from the given URI (path segment or URL) with respect to $apiURL,
 	 * anything except host and path will be ignored, scheme will always be set to "https".
-	 * Throws if the given path is invalid or if the host of a given URL does not match $apiURL.
+	 * Throws if the host of a given URL does not match the host of $apiURL.
 	 *
 	 * @see \chillerlan\OAuth\Core\OAuthInterface::request()
 	 *
@@ -335,12 +335,8 @@ protected function getRequestTarget(string $uri):string{
 
 		// for some reason we were given a host name
 
-		if($parsedURL->getScheme() !== 'https'){
-			throw new ProviderException(sprintf('scheme of the URL (%s) must be "https" if host is given', $parsedURL));
-		}
-
-		// we explicitly ignore any existing parameters here
-		$parsedURL = $parsedURL->withQuery('')->withFragment('');
+		// we explicitly ignore any existing parameters here and enforce https
+		$parsedURL = $parsedURL->withScheme('https')->withQuery('')->withFragment('');
 		$apiHost   = $api->getHost();
 
 		if($parsedHost === $apiHost){
@@ -362,7 +358,6 @@ protected function getRequestTarget(string $uri):string{
 			return (string)$parsedURL;
 		}
 
-		// back out if it doesn't match
 		throw new ProviderException(sprintf('given host (%s) does not match provider (%s)', $parsedHost , $apiHost));
 	}
 

src/Providers/BattleNet.php

@@ -83,14 +83,10 @@ protected function getRequestTarget(string $uri):string{
 
 		// for some reason we were given a host name
 
-		if($parsedURL->getScheme() !== 'https'){
-			throw new ProviderException(sprintf('scheme of the URL (%s) must be "https" if host is given', $parsedURL));
-		}
-
 		// shortcut here for the known domains
 		if(in_array($parsedHost, $this::KNOWN_DOMAINS, true)){
 			// we explicitly ignore any existing parameters here
-			return (string)$parsedURL->withQuery('')->withFragment('');
+			return (string)$parsedURL->withScheme('https')->withQuery('')->withFragment('');
 		}
 
 		// back out if it doesn't match