chore(nextjs): Improve observability on keyless failures #5325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 3f1803d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
commented
Mar 17, 2025
| const accountlessApplication = await client.__experimental_accountlessApplications | ||
| .createAccountlessApplication() | ||
| .catch(() => null); | ||
| const accountlessApplication = await client.__experimental_accountlessApplications.createAccountlessApplication(); |
There was a problem hiding this comment.
Let the error bubble up, catch it and log it.
Comment on lines
+25
to
+28
| /** | ||
| * | ||
| */ | ||
| debug?: boolean; |
There was a problem hiding this comment.
Maybe a generic CLERK_DEBUG env var ?
|
I am closing this, the refactor was done in here #5389 and we decided to pass on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR abstracts the keyless implementation under the
KeylessProvider(RSC) and also allows for logs to be displayed when<ClerkProvide debug/>for data related to keyless. I remind you that when keyless fails for any reason, we display an error the a PK needs to be provided, since this is the action the developer needs to perform in order to proceed.In cases where keyless is expected to work, but fails to do so, it is usefully to have such logs to determine, what makes the feature to fail.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change