Strip periods, spaces for batch file filtering on Windows #15573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #15560
As discussed in the linked issue, the options on the table are either
. This PR does the latter.
GetFullPathNameW
or stripping trailing.
andHere's a benchmark between them, the difference seems insignificant, considering executing is going to take longer. Stripping is faster anyway.
Draft until the CI finishes because I haven't actually tested on Windows.I don't like the commit name that much but it's the most descriptive one I could come up with.