Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Softplus activation #15

Merged
merged 4 commits into from
Jul 11, 2019
Merged

Softplus activation #15

merged 4 commits into from
Jul 11, 2019

Conversation

jeffin07
Copy link
Contributor

@jeffin07 jeffin07 commented Jul 10, 2019

Implemented SoftPlus activation mentioned in #7
tested with test.py
plot

files changed

acivations.py
plots.py
tests.py
tests/tests.py

@WuZhuoran
Copy link
Contributor

You can create unit test base on @ddbourgin example:

Thanks for these! I haven't finished going through them, but if you could include unit tests against the existing PyTorch implementations (see my hacky examples here for reference), that would help a ton.

You can also refer #8 pull request for further example of unit test.

@jeffin07
Copy link
Contributor Author

@WuZhuoran I updated the PR with unit test

@ddbourgin
Copy link
Owner

@jeffin07 - This is great! I've taken a quick glance, and this looks basically perfect. I'll go over in a bit more detail tonight, but should be able to merge shortly.

@ddbourgin
Copy link
Owner

Beautiful. Fixed small bugs in the unit tests and now we're ready to go. Merging!

@ddbourgin ddbourgin merged commit ebd62eb into ddbourgin:master Jul 11, 2019
@jeffin07 jeffin07 deleted the softplus branch July 11, 2019 05:02
lew91 pushed a commit to lew91/numpy-ml that referenced this pull request Sep 11, 2020
Add SoftPlus activation and unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants