Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failover Slots #31

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Failover Slots #31

merged 4 commits into from
Nov 26, 2024

Conversation

gunnarmorling
Copy link
Contributor

No description provided.

@gunnarmorling gunnarmorling marked this pull request as draft November 19, 2024 13:00
@gunnarmorling gunnarmorling requested a review from rmoff November 19, 2024 13:00
@rmoff
Copy link
Contributor

rmoff commented Nov 19, 2024

@gunnarmorling reminder to add entry to the root README :)

@gunnarmorling gunnarmorling changed the title [Failover Slots] WIP Failover Slots Nov 25, 2024
@gunnarmorling gunnarmorling marked this pull request as ready for review November 25, 2024 17:20
Copy link
Contributor

@rmoff rmoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but two non-blocking nits/comments

# Failover Slots with Postgres 17

This example shows the usage of Postgres 17 failover replication slots with Postgres SQL-based interface to logical replication as well as with Decodable.
It accompanies the blog post <TODO>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny nit: is it better to just put decodable.co/blog and then change it once the URL is live? that way if you forget / someone gets to the readme before you update it, they don't have a dead link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, hum, I don't it makes a huge difference. I just should not forget to update the link after publishing the post :)

@gunnarmorling gunnarmorling merged commit f8c8dfb into main Nov 26, 2024
3 checks passed
@gunnarmorling gunnarmorling deleted the failover_slots branch November 26, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants