feat: time extension for ChatPromptBuilder

[mathislucka]

Related Issues

• fixes #8985
  

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

• I have read the contributors guidelines and the code of conduct
• I have updated the related issue with new insights and changes
• I added unit tests and updated the docstrings
• I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
• I documented my code
• I ran pre-commit hooks and fixed any issue

[coveralls]

Pull Request Test Coverage Report for Build 13947198075

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 4 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.01%) to 90.054%

---

Files with Coverage Reduction	New Missed Lines	%
components/builders/chat_prompt_builder.py	4	93.67%

Totals
Change from base Build 13945256266:	-0.01%
Covered Lines:	9742
Relevant Lines:	10818

---

💛 - Coveralls

[sjrl]

@mathislucka thanks for your work on this! I do realize this is a similar implementation as in PromptBuilder but I did want to ask what happens if arrow is not installed and a user still tries to request a date? Will they get an informative error message that they are missing the install?

[mathislucka]

@mathislucka thanks for your work on this! I do realize this is a similar implementation as in PromptBuilder but I did want to ask what happens if arrow is not installed and a user still tries to request a date? Will they get an informative error message that they are missing the install?

I believe they would not get an error or warning but I'm not sure how that could be implemented. At init time we could log a warning when the time extension is not installed (instead of just silently swallowing the ImportError) but I don't think it would be practical to try and parse the template itself to determine if a user attempts to use date rendering or not.

Should I add just the warning? Or do you have a better idea?

[sjrl]

So this is the type of error they would get jinja2.exceptions.TemplateSyntaxError: Encountered unknown tag 'now'. at runtime.

I'm not sure if a warning makes sense since it's not a true warning if they aren't using the time extension.

[mathislucka]

No, I mean we could add a warning at init time where we say something like:

Install arrow if you want to use the time extension. (ideally with a link to the docs for what the time extension is / does)

[sjrl]

No, I mean we could add a warning at init time where we say something like:

Install arrow if you want to use the time extension. (ideally with a link to the docs for what the time extension is / does)

Right I understand but I thought that might be an annoying warning to get as a user if they don’t plan on using the time extension. Although I think you’re right that it’s better to add that there so users are aware what to do to enable it. So I’d say go ahead and add it.

[sjrl]

I think it's fine to leave out the warning message for now and just document how to use the time extension in docs.