-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat: add split_by_row
feature to CSVDocumentSplitter
#9031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3776170
Add split by row feature
Amnah199 f1f7640
Add release notes
Amnah199 3238890
Add edge case test
Amnah199 f1a0171
fix linting
Amnah199 e9e3792
PR comments
Amnah199 4b394f5
Add literal test
Amnah199 55e946d
Small fixes
Amnah199 ee89da1
PR comments
Amnah199 ce06a23
Merge branch 'main' into add-split-by-row-csv-splitter
Amnah199 67c88b5
fix linting
Amnah199 893c440
Merge branch 'add-split-by-row-csv-splitter' of https://github.com/de…
Amnah199 0a9f9ec
Final changes
Amnah199 9c45e95
Merge branch 'main' into add-split-by-row-csv-splitter
Amnah199 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
releasenotes/notes/add-split-by-row-csv-splitter-e810b96b0db287b3.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
features: | ||
- | | ||
Added a new parameter `split_mode` to the `CSVDocumentSplitter` component to control the splitting mode. | ||
The new parameter can be set to `row-wise` to split the CSV file by rows. | ||
The default value is `threshold`, which is the previous behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.