Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compatibility checks for Callable types #9033

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add compatibility checks for Callable types #9033

wants to merge 2 commits into from

Conversation

mdrazak2001
Copy link
Contributor

@mdrazak2001 mdrazak2001 commented Mar 12, 2025 •
edited
Loading

Related Issues

Proposed Changes:

  • Modified the type validation function to utilize _check_callable_compatibility for callable bare types.
  • Include new test cases to verify the updated behavior.

How did you test it?

  • added unit tests

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@mdrazak2001 mdrazak2001 requested a review from a team as a code owner March 12, 2025 19:51
@mdrazak2001 mdrazak2001 requested review from mpangrazzi and removed request for a team March 12, 2025 19:51
@mdrazak2001 mdrazak2001 requested a review from a team as a code owner March 12, 2025 19:55
@mdrazak2001 mdrazak2001 requested review from dfokina and removed request for a team March 12, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpangrazzi mpangrazzi

@dfokina dfokina

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
topic:core topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance Type Validation to Handle Callable Bare Types
1 participant
@mdrazak2001