Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added retries parameters to pipeline.draw() #9055

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

nickprock
Copy link
Contributor

Related Issues

Proposed Changes:

  • Implemented an exponential retry mechanism
  • Added max_retries and initial_delay parameters to control retry behavior and allow more customization
  • Included unit test to check the correct operation of the retry mechanism and exponential backoff

How did you test it?

unit tests

Notes for the reviewer

@anakin87 check if it's ok, you are cited in the issue.

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@nickprock nickprock requested review from a team as code owners March 18, 2025 10:43
@nickprock nickprock requested review from dfokina and Amnah199 and removed request for a team March 18, 2025 10:43
@coveralls
Copy link
Collaborator

coveralls commented Mar 18, 2025

Pull Request Test Coverage Report for Build 13922026747

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.006%) to 90.076%

Files with Coverage Reduction New Missed Lines %
core/pipeline/draw.py 8 87.9%
Totals Coverage Status
Change from base Build 13920793695: 0.006%
Covered Lines: 9730
Relevant Lines: 10802

💛 - Coveralls

fixed too many positional arguments error
@davidsbatista
Copy link
Contributor

This is good, and I agree with the PR, but in the future, we probably should:

  • only run this test if this file is changed in a PR and not for every single PR
  • make sure that, regardless of changes, it runs at least 1 or 2 a week

My point is that running it for every PR might be a might too much charge for mermaid servers - alternatively, we can also host a Docker with a mermaid server and run against that server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add retries parameter to pipeline.draw() to help mitigate mermaid server issues
3 participants