Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EvaluationRunResult casting scores from numpy to float #9056

Closed
wants to merge 3 commits into from

Conversation

davidsbatista
Copy link
Contributor

@davidsbatista davidsbatista commented Mar 18, 2025

Proposed Changes:

converting scores to str instead of np.float

{'metrics': ['doc_mrr_evaluator', 'faithfulness', 'sas_evaluator'],
 'score': [1.0, np.float64(1.0), np.float64(0.7126952672004699)]}

it looks like this

{'metrics': ['doc_mrr_evaluator', 'faithfulness', 'sas_evaluator'],
 'score': ['1.0', '1.0', '0.7126952672004699']}

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@coveralls
Copy link
Collaborator

coveralls commented Mar 18, 2025

Pull Request Test Coverage Report for Build 13923597466

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 90.07%

Files with Coverage Reduction New Missed Lines %
evaluation/eval_run_result.py 6 61.96%
Totals Coverage Status
Change from base Build 13920793695: 0.0%
Covered Lines: 9724
Relevant Lines: 10796

💛 - Coveralls

@davidsbatista davidsbatista added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Mar 18, 2025
@davidsbatista davidsbatista marked this pull request as ready for review March 18, 2025 12:48
@davidsbatista davidsbatista requested a review from a team as a code owner March 18, 2025 12:48
@davidsbatista davidsbatista requested review from sjrl and removed request for a team March 18, 2025 12:48
@sjrl
Copy link
Contributor

sjrl commented Mar 18, 2025

@davidsbatista why do we need to cast to string instead of using np.float?

@davidsbatista
Copy link
Contributor Author

@sjrl see Proposed Changes on the PR notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants