Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: OpenAIChatGenerator - relax flaky test #9075

Merged
merged 2 commits into from
Mar 20, 2025
Merged

test: OpenAIChatGenerator - relax flaky test #9075

merged 2 commits into from
Mar 20, 2025

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Mar 19, 2025 •
edited
Loading

Related Issues

Proposed Changes:

  • relax the flaky test

How did you test it?

CI

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@anakin87 anakin87 changed the title test: OpenAIChatGenerator - fix flaky test test: OpenAIChatGenerator - relax flaky test Mar 19, 2025
@anakin87 anakin87 marked this pull request as ready for review March 19, 2025 18:22
@anakin87 anakin87 requested a review from a team as a code owner March 19, 2025 18:22
@anakin87 anakin87 requested review from Amnah199 and removed request for a team March 19, 2025 18:22
@coveralls
Copy link
Collaborator

coveralls commented Mar 19, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13969933718

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.017%
Totals Coverage Status
Change from base Build 13969901757: 0.0%
Covered Lines: 9820
Relevant Lines: 10909
💛 - Coveralls

@anakin87 anakin87 enabled auto-merge (squash) March 20, 2025 14:16
@anakin87 anakin87 merged commit 67ab378 into main Mar 20, 2025
15 checks passed
@anakin87 anakin87 deleted the fix-openai-flaky-test branch March 20, 2025 14:29
@anakin87 anakin87 mentioned this pull request Mar 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amnah199 Amnah199

Assignees
No one assigned
Labels
topic:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anakin87 @coveralls @Amnah199