Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fixing docstrings #9092

Merged
merged 1 commit into from
Mar 23, 2025
Merged

docs: fixing docstrings #9092

merged 1 commit into from
Mar 23, 2025

Conversation

davidsbatista
Copy link
Contributor

Proposed Changes:

  • adding missing parameter in whisper local docstrings

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@davidsbatista davidsbatista added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Mar 21, 2025
@github-actions github-actions bot added the type:documentation Improvements on the docs label Mar 21, 2025
@davidsbatista davidsbatista marked this pull request as ready for review March 21, 2025 17:43
@davidsbatista davidsbatista requested a review from a team as a code owner March 21, 2025 17:43
@davidsbatista davidsbatista requested review from sjrl and removed request for a team March 21, 2025 17:43
@julian-risch julian-risch requested review from julian-risch and removed request for sjrl March 21, 2025 18:10
julian-risch
julian-risch approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
Interesting that we never exposed the same parameter in the run method of the RemoteWhisperTranscriber.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13997715518

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.016%
Totals Coverage Status
Change from base Build 13997282864: 0.0%
Covered Lines: 9827
Relevant Lines: 10917
💛 - Coveralls

@davidsbatista davidsbatista enabled auto-merge (squash) March 22, 2025 14:30
@davidsbatista davidsbatista merged commit dae8c7b into main Mar 23, 2025
29 of 30 checks passed
@davidsbatista davidsbatista deleted the docs/fixing-local-whisper-docstrings branch March 23, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidsbatista @coveralls @julian-risch