Support constants in custom storage layout expression #15944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusaaguiar
force-pushed
the
allowConstantsCustomStorageLayout
branch
2 times, most recently
from
944dc30 to
059349f
Compare
matheusaaguiar
force-pushed
the
allowConstantsCustomStorageLayout
branch
from
4aae044 to
00ee32e
Compare
matheusaaguiar
commented
Mar 27, 2025
| "The base slot of the storage layout must evaluate to an integer." | ||
| ); | ||
| return; | ||
| if (integerType->isSigned()) |
There was a problem hiding this comment.
This could also be removed from here and then replace the assert in line 173 as suggested in a previous PR #15528 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #15727.