Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Simplify reset password logic by removing duplicate code #1440

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
13 changes: 7 additions & 6 deletions backend/app/api/routes/login.py
Original file line number Diff line number Diff line change
@@ -9,8 +9,7 @@
from app.api.deps import CurrentUser, SessionDep, get_current_active_superuser
from app.core import security
from app.core.config import settings
from app.core.security import get_password_hash
from app.models import Message, NewPassword, Token, UserPublic
from app.models import Message, NewPassword, Token, UserPublic, UserUpdate
from app.utils import (
generate_password_reset_token,
generate_reset_password_email,
@@ -91,10 +90,12 @@ def reset_password(session: SessionDep, body: NewPassword) -> Message:
)
elif not user.is_active:
raise HTTPException(status_code=400, detail="Inactive user")
hashed_password = get_password_hash(password=body.new_password)
user.hashed_password = hashed_password
session.add(user)
session.commit()
user_in_update = UserUpdate(password=body.new_password)
crud.update_user(
session=session,
db_user=user,
user_in=user_in_update,
)
return Message(message="Password updated successfully")


Loading
Oops, something went wrong.