-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FirebaseAuthFallbackService memory leak #2387
Comments
I found a few problems with this issue:
|
Hi, thanks for reaching out. I've filed a bug internally for tracking. (b/179034484) |
Is there any ETA for a fix or an older version we can revert to? I'm getting a lot of memory leak reports from leakcanary for this issue |
[READ] Step 1: Are you in the right place?yes [REQUIRED] Step 2: Describe your environmentAndroid Studio version: 4.2 Beta 6 [REQUIRED] Step 3: Describe the problemLeakCanary is telling me that "FirebaseAuthFallbackService " is leaking. Steps to reproduce:
Relevant Code:
|
Hi, I am getting the same issue in my application too. Is there any fix to prevent this from leaking? |
I am also facing this issue. Any fixes? |
I am also facing this issue. |
I am getting this issue frequently whenever I am exiting the app or going into the background from my app.
Is there any progress on the fix of this issue? |
I heard that they will assign this to a software engineer intern in summer of 2035 |
The Firebase team should definitely fix this bug in FirebaseAuthFallbackService. In the meantime, here's how you can configure LeakCanary to stop tracking FirebaseAuthFallbackService: First, disable the automatic install: <?xml version="1.0" encoding="utf-8"?>
<resources>
<bool name="leak_canary_watcher_auto_install">false</bool>
</resources> Then install LeakCanary manually in your debug application, ignoring FirebaseAuthFallbackService: class DebugExampleApplication : ExampleApplication() {
override fun onCreate() {
super.onCreate()
val delegate = ReachabilityWatcher { watchedObject, description ->
if (watchedObject::class.java.name != "com.google.firebase.auth.api.fallback.service.FirebaseAuthFallbackService
instance") {
AppWatcher.objectWatcher.expectWeaklyReachable(watchedObject, description)
}
}
val watchersToInstall = AppWatcher.appDefaultWatchers(application, delegate)
AppWatcher.manualInstall(
application = application,
watchersToInstall = watchersToInstall
)
}
} |
@pyricau silencing it is easy, but more important is, does it lead to app crash? We run 24/7 kiosk application and ours crash once in a while. We're trying to figure it out :( |
+1 |
Also seeing this issue, which causes our team to check leaks less often, since they all assume it's this specific leak we can't do anything about. Would love to see it fixed on the firebase side |
This issue is Causing ANR in my app |
Also getting ANRs from this. |
+1 |
@Brian605 Have you come up with a fair solution? |
Someone from the firebase team should look into this urgently! |
Hey firebase team will you address this issue? We are getting tons of ANR's because of this! |
+1 |
+1, Please fix that issue. We have a lot of ANRs in the app because of that. |
Still not fixed.. 😢 |
Hey folks, sorry that it's taking this long. I've forwarded this issue to the Auth team, there is an internal bug tracking progress for this. cc @malcolmdeck Thanks for your patience. |
Why did this issue suddenly get traffic? |
Cause a lot of anr, the version can’t be sent out |
+1 |
1 similar comment
+1 |
Hope this gets fixed soon |
+1 |
1 similar comment
+1 |
+1 |
1 similar comment
+1 |
I'm just going to leave this here: https://twitter.com/Piwai/status/1473315039188762632 😉 |
This issue seems to also cause other memory leaks that seem to be totally unrelated at first glance; see #3236. |
Today is Jan 1, 2022, the issue was reported on Jan 31, 2021... |
It seems that I have probably more information about this issue, which I have described in #3300. It looks that it can happen when upgrading libraries. In our environment we used following versions:
which has been lately upgraded (+ added database/auth) to BoM format:
After running the new app, it looks that Firebase Crashlytics tries to read some files which are no longer there:
it tries to do that many times per second through 20s+ which basically hammers the app and gives ANR later. This only happens directly after library upgrade. |
As Malcolm mentioned in the comment, we have an on-going refactoring. We will update this thread once we test the refactoring and get it ready for release. |
@yoyomyo thanks for working on the fix! I'm curious if there is an ETA for a fix for this as I am struggling to get around this and it's a show stopper for my app. |
After @malcolmdeck finished the refactoring, I am able to verify that the memory leak is no longer reproducible in the latest firebase-auth pre-release library. Will follow up here when the release goes out. |
Is there any update on this issue? Which Firebase library version has fix of this issue? |
Echoing @mohitrajput-trell - I'd love to test a patched build of this if information is forthcoming :) |
Here are the logs from Leak Canary:
SDKs Version:
Let me know if you still want to customized APK for this. |
There was a new 29.1.0 BOM, however I don't see this fix mentioned and I am still getting the crash/ANR. @malcolmdeck and @yoyomyo, can either of you confirm whether or not this fix made it into that release? |
The fix is not in 29.1.0 yet. Please be patient, as the BOM testing and release process can take some time. We will update this thread as soon as we have more details. |
I'm facing the same issue |
I have also this issue in 29.1.0. |
@yoyomyo Can you please give an estimation of the time frame that you expect to have a version with this problem fix, days, weeks or months? |
Hi all, thank you for your patience! The fix is finally out in Firebase Authentication version |
This release fixed the startup issues I was having with our new app. Thanks for your hard work! |
[READ] Step 1: Are you in the right place?
yes
[REQUIRED] Step 2: Describe your environment
[REQUIRED] Step 3: Describe the problem
LeakCanary is telling me that "FirebaseAuthFallbackService " is leaking.
I just "AuthStateListener" in my ActivityClass which lives through the entire app lifecycle, to check if the user signed out.
And "Firebase.auth" for taking currentUser instance. That's all
Steps to reproduce:
Happening every time I open the app, sometimes when I close the app, sometimes when It goes to the background, LeakCanary starts dumping the heap and throwing this memory leak.
Relevant Code:
The text was updated successfully, but these errors were encountered: