Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App distribution redirect to an old Aritfact after uploading same apk with same version number #6662

Closed
Abdelsattar opened this issue Feb 3, 2025 · 5 comments

Comments

@Abdelsattar
Copy link

Abdelsattar commented Feb 3, 2025

[REQUIRED] Step 2: Describe your environment

  • Android Studio version: Ladybug | 2024.2.1 Patch 1
  • Firebase Component: api:appdistribution
  • Component version: 5.0.0

[REQUIRED] Step 3: Describe the problem

Steps to reproduce:

What happened? How can we make the problem occur?
This could be a description, log/console output, etc.

  • When we upload the same app from our app with the same version and the same MESSAGE it does not override the old one in Firebase app Distribution even though we get successful results, and the links are actually redirected to an old artifact uploaded 5 days ago

Result:

Uploaded APK successfully 200
Added release notes successfully 200
Added testers/groups successfully 200
View this release in the Firebase console: https://console.firebase.google.com/project/****
Share this release with testers who have access: https://appdistribution.firebase.google.com/testerapps/****
Download the release binary (link expires in 1 hour): https://firebaseappdistribution.googleapis.com/app-binary-downloads/projects/***
App Distribution upload finished successfully!

Relevant Code:

we have this job in our pipeline

      - name: Distribute to Firebase
        run: ./gradlew packageDebug appDistributionUploadDebug --releaseNotes="$MESSAGE"
@google-oss-bot
Copy link
Contributor

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@lehcar09
Copy link
Contributor

lehcar09 commented Feb 3, 2025

Hi @Abdelsattar, thank you for reaching out. I tried reproducing the behavior and I was able to reproduce it. Per checking, this is working as intended. If the CRC32 checksums in the APK (or AAB) don't change, we don't create a new release. If any single bit (of the uncompressed binary) is different, then a new release is created - even if versions and build numbers are identical.

With that, I'll be closing this issue now. Let me know if there's any misunderstanding so we can re-open the issue. Thanks!

@lehcar09 lehcar09 closed this as completed Feb 3, 2025
@Abdelsattar
Copy link
Author

Hi @lehcar09 , Thanks for taking the time for investigation, you are right nothing have changed in the app as it was created a while ago from the same commit, but at the end it cost us a day of investigation due to misleading message
which is

Uploaded APK successfully 200.  --> no new apk uploaded
Added release notes successfully 200
Added testers/groups successfully 200
View this release in the Firebase console: https://console.firebase.google.com/project/****
Share this release with testers who have access: https://appdistribution.firebase.google.com/testerapps/**** --> 
Download the release binary (link expires in 1 hour): https://firebaseappdistribution.googleapis.com/app-binary-downloads/projects/***
App Distribution upload finished successfully! -> no new app Distribution uploaded.

I'll request changing the response messages to clearly saying at least " No new APK uploaded: Existing version matches current changes
A version of this APK ([Version Code] / [Version Name]) with identical content already exist."

Many Thanks.

@lehcar09 lehcar09 reopened this Feb 4, 2025
@lehcar09 lehcar09 added the type: feature request New feature or request label Feb 4, 2025
@lehcar09
Copy link
Contributor

lehcar09 commented Feb 4, 2025

I'll go ahead and mark this as a feature request. Internally tracking in b/394284067. While we are unable to promise any timeline for this, we'll definitely keep this under our radar.

P.S. For folks who find this useful, adding an emoji thumbs up on the original post can help us prioritize adding this to the roadmap.

@kaibolay
Copy link
Contributor

kaibolay commented Feb 7, 2025

This should be fixed in version 5.1.1 of the gradle plugin which was just released.

@kaibolay kaibolay closed this as completed Feb 7, 2025
@firebase firebase locked and limited conversation to collaborators Mar 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants