You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need to consider a cleaner way to support thread safety of FIRApp. It was brought up as a result of #2639 (see related issue, discussions and history)
Right now @synchronized(self) is used for this purpose. The main disadvantages of this approach is:
it requires extra attention from a developer modifying the class. It is easy to miss when new logic is implemented. In fact, the original issue happened juts because some places where missed
In addition:
it may lead to unintentional blocking of main thread by a background task
it is possible to introduce a deadlock
The text was updated successfully, but these errors were encountered:
We need to consider a cleaner way to support thread safety of
FIRApp
. It was brought up as a result of #2639 (see related issue, discussions and history)Right now
@synchronized(self)
is used for this purpose. The main disadvantages of this approach is:In addition:
The text was updated successfully, but these errors were encountered: