Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIRApp refactoring - thread safety #2640

Open
maksymmalyhin opened this issue Mar 26, 2019 · 1 comment
Open

FIRApp refactoring - thread safety #2640

maksymmalyhin opened this issue Mar 26, 2019 · 1 comment

Comments

@maksymmalyhin
Copy link
Contributor

maksymmalyhin commented Mar 26, 2019

We need to consider a cleaner way to support thread safety of FIRApp. It was brought up as a result of #2639 (see related issue, discussions and history)

Right now @synchronized(self) is used for this purpose. The main disadvantages of this approach is:

  • it requires extra attention from a developer modifying the class. It is easy to miss when new logic is implemented. In fact, the original issue happened juts because some places where missed

In addition:

  • it may lead to unintentional blocking of main thread by a background task
  • it is possible to introduce a deadlock
@ryanwilson
Copy link
Member

Will likely wait until there's an actual issue reported before we go in and start changing the threading mechanism for Core.

@ncooke3 ncooke3 assigned ncooke3 and unassigned maksymmalyhin Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants