Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Servercache bug #6976

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Fix Servercache bug #6976

wants to merge 6 commits into from

Conversation

maneesht
Copy link
Contributor

Initialized serverCache to undefined until an operation is applied, and used that to prevent unknown deep merges.

@maneesht maneesht requested review from jsdt and jmwski as code owners January 24, 2023 19:53
@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2023

🦋 Changeset detected

Latest commit: 8695218

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/database Patch
@firebase/database-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maneesht maneesht requested a review from egilmorez as a code owner January 24, 2023 20:02
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 24, 2023

Size Report 1

Affected Products

  • @firebase/database

    TypeBase (4604b3c)Merge (d95a390)Diff
    browser248 kB248 kB+23 B (+0.0%)
    esm5276 kB276 kB+23 B (+0.0%)
    main281 kB281 kB+23 B (+0.0%)
    module248 kB248 kB+23 B (+0.0%)
  • @firebase/database-compat/standalone

    TypeBase (4604b3c)Merge (d95a390)Diff
    main370 kB370 kB+23 B (+0.0%)
  • bundle

    TypeBase (4604b3c)Merge (d95a390)Diff
    database (Append to a list of data)148 kB148 kB+8 B (+0.0%)
    database (Filtering data)147 kB147 kB+8 B (+0.0%)
    database (Listen for child events)163 kB164 kB+5 B (+0.0%)
    database (Listen for value events + Detach listeners)163 kB163 kB+5 B (+0.0%)
    database (Listen for value events)163 kB163 kB+5 B (+0.0%)
    database (Read data once)163 kB163 kB+9 B (+0.0%)
    database (Save data as transactions)165 kB165 kB+5 B (+0.0%)
    database (Sort data)149 kB149 kB+8 B (+0.0%)
    database (Write data)147 kB147 kB+8 B (+0.0%)
  • firebase

    TypeBase (4604b3c)Merge (d95a390)Diff
    firebase-compat.js746 kB746 kB+2 B (+0.0%)
    firebase-database-compat.js166 kB166 kB+2 B (+0.0%)
    firebase-database.js154 kB154 kB+2 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VGFIugsaq7.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 24, 2023

Size Analysis Report 1

This report is too large (99,544 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6OtPxIZ8ao.html

@maneesht maneesht marked this pull request as draft May 23, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants