Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Merge PR #8735

Open
wants to merge 37 commits into
base: feat/pipelines
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
acbf24f
add pipeline to Listen RPC
wu-hui Oct 15, 2024
93fdb23
Prepre for serializaion/deserialization
wu-hui Oct 17, 2024
8ac835e
fix rebase error
wu-hui Oct 17, 2024
422723a
quick hack to integrate with watch.
wu-hui Oct 21, 2024
ee64690
add api/pipelinesource and setup basic listen test
wu-hui Oct 31, 2024
1738c15
watch integration works.
wu-hui Nov 6, 2024
946a266
add pipeline canonify and eq
wu-hui Oct 22, 2024
6fc2050
runPipeline initial
wu-hui Oct 25, 2024
377e82f
initial offline function evaluation
wu-hui Oct 29, 2024
2b244a2
add basic tests for pipeline eval
wu-hui Oct 29, 2024
23b5135
runPipeline initial
wu-hui Oct 25, 2024
82b8303
Setting up QueryOrPipeline to replace Query
wu-hui Oct 30, 2024
7a3e789
type1 compiles
wu-hui Nov 12, 2024
4d7d917
introduce new variant for query_engine.test.ts
wu-hui Nov 13, 2024
c274177
Fix core/expression rebase error
wu-hui Nov 13, 2024
6e4a7e3
Add basic tests
wu-hui Nov 14, 2024
e6f860e
remove api/pipeline and use the lite one
wu-hui Nov 14, 2024
667c398
query_engine.test.ts pass with pipelines
wu-hui Nov 19, 2024
48a6324
local store tests PASS
wu-hui Nov 25, 2024
6ab2ba5
memory spec tests pass sans limitToLast
wu-hui Nov 28, 2024
58124c4
most spec tests PASS!
wu-hui Dec 2, 2024
0f63a54
limit to last, cursors and multitab for documents and database stages
wu-hui Dec 4, 2024
5945776
Merge remote-tracking branch 'origin/feat/pipelines' into wuandy/offp…
wu-hui Dec 6, 2024
5ad944e
fix merge errors
wu-hui Dec 10, 2024
da4dee3
Add expressions tests
wu-hui Dec 16, 2024
656e848
Ported all tests, plus some bug fixes
wu-hui Dec 19, 2024
90ce598
Merge remote-tracking branch 'origin/feat/pipelines' into wuandy/offp…
wu-hui Dec 19, 2024
34b3e71
fix merge errors
wu-hui Dec 19, 2024
c5678fe
fixed expressions tests
wu-hui Dec 20, 2024
f2a0585
Fixed all incompatibilities
wu-hui Dec 23, 2024
bc9ac99
Add gitignore entries
wu-hui Dec 28, 2024
0212394
Merge with feat/pipelines
wu-hui Dec 28, 2024
5e6cd52
Proto update sync and add query spec tests back
wu-hui Dec 28, 2024
2b4a5ad
merge with feat/pipeline
wu-hui Jan 28, 2025
ffc17e4
merge with feat/pipeline
wu-hui Jan 28, 2025
d2b18f9
Fix circular dependency caused by import from api_pipelines. Also sim…
MarkDuckworth Jan 29, 2025
d49ff96
Merge branch 'push-vwqlstsxuovu' of github.com:firebase/firebase-js-s…
MarkDuckworth Jan 29, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'origin/feat/pipelines' into wuandy/offp…
…pl-type1

# Conflicts:
#	packages/firestore/package.json
#	packages/firestore/src/api/pipeline.ts
#	packages/firestore/src/api/pipeline_impl.ts
#	packages/firestore/src/core/firestore_client.ts
#	packages/firestore/src/core/pipeline-util.ts
#	packages/firestore/src/lite-api/expressions.ts
#	packages/firestore/src/lite-api/pipeline.ts
#	packages/firestore/src/remote/watch_change.ts
#	packages/firestore/test/integration/api/pipeline.test.ts
#	packages/firestore/test/unit/specs/spec_builder.ts
  • Loading branch information
wu-hui committed Dec 6, 2024
commit 59457764c67a3d16f0b6852954e1de188d8a76f5
7 changes: 0 additions & 7 deletions .changeset/cold-chairs-fold.md

This file was deleted.

5 changes: 5 additions & 0 deletions .changeset/nervous-timers-call.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@firebase/vertexai': patch
---

Update to new base URL in documentation
5 changes: 0 additions & 5 deletions .changeset/sharp-dingos-admire.md

This file was deleted.

5 changes: 5 additions & 0 deletions .changeset/six-toys-chew.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@firebase/vertexai': patch
---

Remove indentation in VertexAI API Not Enabled error
5 changes: 0 additions & 5 deletions .changeset/small-geckos-mix.md

This file was deleted.

5 changes: 5 additions & 0 deletions .changeset/tall-peas-tell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@firebase/vertexai': patch
---

Send App Check dummy token in header if there is an App Check getToken error.
53 changes: 53 additions & 0 deletions .changeset/tame-paws-nail.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
---
'@firebase/analytics': patch
'@firebase/analytics-compat': patch
'@firebase/analytics-interop-types': patch
'@firebase/analytics-types': patch
'@firebase/app': patch
'@firebase/app-check': patch
'@firebase/app-check-compat': patch
'@firebase/app-check-interop-types': patch
'@firebase/app-check-types': patch
'@firebase/app-compat': patch
'@firebase/app-types': patch
'@firebase/auth': patch
'@firebase/auth-compat': patch
'@firebase/auth-interop-types': patch
'@firebase/auth-types': patch
'@firebase/component': patch
'@firebase/data-connect': patch
'@firebase/database': patch
'@firebase/database-compat': patch
'@firebase/database-types': patch
'firebase': patch
'@firebase/firestore': patch
'@firebase/firestore-compat': patch
'@firebase/firestore-types': patch
'@firebase/functions': patch
'@firebase/functions-compat': patch
'@firebase/functions-types': patch
'@firebase/installations': patch
'@firebase/installations-compat': patch
'@firebase/installations-types': patch
'@firebase/logger': patch
'@firebase/messaging': patch
'@firebase/messaging-compat': patch
'@firebase/messaging-interop-types': patch
'@firebase/performance': patch
'@firebase/performance-compat': patch
'@firebase/performance-types': patch
'@firebase/remote-config': patch
'@firebase/remote-config-compat': patch
'@firebase/remote-config-types': patch
'@firebase/rules-unit-testing': patch
'@firebase/storage': patch
'@firebase/storage-compat': patch
'@firebase/storage-types': patch
'@firebase/template': patch
'@firebase/template-types': patch
'@firebase/util': patch
'@firebase/vertexai': patch
'@firebase/webchannel-wrapper': patch
---

Upgrade to TypeScript 5.5.4
5 changes: 5 additions & 0 deletions .changeset/tasty-boxes-brake.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@firebase/firestore": patch
---

Prevent a possible condition of slow snapshots, caused by a rapid series of document update(s) followed by a delete.
3 changes: 3 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -15,6 +15,9 @@ packages/database @maneesht @aashishpatil-g @firebase/jssdk-global-approvers
packages/database-compat @maneesht @aashishpatil-g @firebase/jssdk-global-approvers
packages/database-types @maneesht @aashishpatil-g @firebase/jssdk-global-approvers

# Data Connect Code
packages/data-connect @maneesht @aashishpatil-g @firebase/jssdk-global-approvers

# Firestore Code
packages/firestore @firebase/firestore-js-team @firebase/jssdk-global-approvers
packages/firestore-compat @firebase/firestore-js-team @firebase/jssdk-global-approvers
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/bug_report_v2.yaml
Original file line number Diff line number Diff line change
@@ -63,6 +63,7 @@ body:
- Auth
- Component
- Database
- DataConnect
- Firestore
- Functions
- Installations
4 changes: 2 additions & 2 deletions .github/workflows/canary-deploy.yml
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ jobs:
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 20.x
node-version: 22.10.0
- name: Yarn install
run: yarn
- name: Deploy canary
@@ -71,7 +71,7 @@ jobs:
NPM_TOKEN_STORAGE: ${{secrets.NPM_TOKEN_STORAGE}}
NPM_TOKEN_STORAGE_TYPES: ${{secrets.NPM_TOKEN_STORAGE_TYPES}}
NPM_TOKEN_UTIL: ${{secrets.NPM_TOKEN_UTIL}}
NPM_TOKEN_VERTEXAI_PREVIEW: ${{secrets.NPM_TOKEN_VERTEXAI_PREVIEW}}
NPM_TOKEN_VERTEXAI: ${{secrets.NPM_TOKEN_VERTEXAI}}
NPM_TOKEN_WEBCHANNEL_WRAPPER: ${{secrets.NPM_TOKEN_WEBCHANNEL_WRAPPER}}
NPM_TOKEN_FIREBASE: ${{secrets.NPM_TOKEN_FIREBASE}}
NPM_TOKEN_APP_COMPAT: ${{ secrets.NPM_TOKEN_APP_COMPAT }}
2 changes: 1 addition & 1 deletion .github/workflows/check-changeset.yml
Original file line number Diff line number Diff line change
@@ -37,7 +37,7 @@ jobs:
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 20.x
node-version: 22.10.0
- name: Yarn install
run: yarn
- name: Run changeset script
2 changes: 1 addition & 1 deletion .github/workflows/check-docs.yml
Original file line number Diff line number Diff line change
@@ -30,7 +30,7 @@ jobs:
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 20.x
node-version: 22.10.0
- name: Yarn install
run: yarn
- name: Run doc generation
2 changes: 1 addition & 1 deletion .github/workflows/check-pkg-paths.yml
Original file line number Diff line number Diff line change
@@ -30,7 +30,7 @@ jobs:
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 20.x
node-version: 22.10.0
- name: Yarn install
run: yarn
- name: Yarn build
2 changes: 1 addition & 1 deletion .github/workflows/deploy-config.yml
Original file line number Diff line number Diff line change
@@ -38,7 +38,7 @@ jobs:
- name: Set up node (20)
uses: actions/setup-node@v3
with:
node-version: 20.x
node-version: 22.10.0
- name: Yarn install
run: yarn
- name: Deploy project config if needed
2 changes: 1 addition & 1 deletion .github/workflows/e2e-test.yml
Original file line number Diff line number Diff line change
@@ -39,7 +39,7 @@ jobs:
- name: Set up Node (20)
uses: actions/setup-node@master
with:
node-version: 20.x
node-version: 22.10.0
- name: install Chrome stable
run: |
sudo apt-get update
2 changes: 1 addition & 1 deletion .github/workflows/format.yml
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ jobs:
- name: Set up node (20)
uses: actions/setup-node@v3
with:
node-version: 20.x
node-version: 22.10.0
- name: Yarn install
run: yarn
- name: Run formatting script
4 changes: 2 additions & 2 deletions .github/workflows/health-metrics-pull-request.yml
Original file line number Diff line number Diff line change
@@ -41,7 +41,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 20.x
node-version: 22.10.0
- uses: 'google-github-actions/auth@v0'
with:
credentials_json: '${{ secrets.GCP_SA_KEY }}'
@@ -58,7 +58,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 20.x
node-version: 22.10.0
- uses: 'google-github-actions/auth@v0'
with:
credentials_json: '${{ secrets.GCP_SA_KEY }}'
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@ jobs:
- name: Set up node (20)
uses: actions/setup-node@v3
with:
node-version: 20.x
node-version: 22.10.0
- name: yarn install
run: yarn
- name: yarn lint
4 changes: 2 additions & 2 deletions .github/workflows/prerelease-manual-deploy.yml
Original file line number Diff line number Diff line change
@@ -37,7 +37,7 @@ jobs:
- name: Set up node (20)
uses: actions/setup-node@v3
with:
node-version: 20.x
node-version: 22.10.0
- name: Yarn install
run: yarn
- name: Deploy prerelease
@@ -74,7 +74,7 @@ jobs:
NPM_TOKEN_STORAGE: ${{secrets.NPM_TOKEN_STORAGE}}
NPM_TOKEN_STORAGE_TYPES: ${{secrets.NPM_TOKEN_STORAGE_TYPES}}
NPM_TOKEN_UTIL: ${{secrets.NPM_TOKEN_UTIL}}
NPM_TOKEN_VERTEXAI_PREVIEW: ${{secrets.NPM_TOKEN_VERTEXAI_PREVIEW}}
NPM_TOKEN_VERTEXAI: ${{secrets.NPM_TOKEN_VERTEXAI}}
NPM_TOKEN_WEBCHANNEL_WRAPPER: ${{secrets.NPM_TOKEN_WEBCHANNEL_WRAPPER}}
NPM_TOKEN_FIREBASE: ${{secrets.NPM_TOKEN_FIREBASE}}
NPM_TOKEN_APP_COMPAT: ${{ secrets.NPM_TOKEN_APP_COMPAT }}
2 changes: 1 addition & 1 deletion .github/workflows/release-log.yml
Original file line number Diff line number Diff line change
@@ -31,7 +31,7 @@ jobs:
- name: Setup Node.js 20.x
uses: actions/setup-node@master
with:
node-version: 20.x
node-version: 22.10.0

- name: Get PR number and send to tracker.
run: node scripts/ci/log-changesets.js
2 changes: 1 addition & 1 deletion .github/workflows/release-pr.yml
Original file line number Diff line number Diff line change
@@ -35,7 +35,7 @@ jobs:
- name: Setup Node.js 20.x
uses: actions/setup-node@master
with:
node-version: 20.x
node-version: 22.10.0

- name: Install Dependencies
run: yarn
4 changes: 2 additions & 2 deletions .github/workflows/release-prod.yml
Original file line number Diff line number Diff line change
@@ -35,7 +35,7 @@ jobs:
- name: Set up node (20)
uses: actions/setup-node@v3
with:
node-version: 20.x
node-version: 22.10.0
- name: Checkout release branch (with history)
uses: actions/checkout@v4
with:
@@ -84,7 +84,7 @@ jobs:
NPM_TOKEN_STORAGE: ${{secrets.NPM_TOKEN_STORAGE}}
NPM_TOKEN_STORAGE_TYPES: ${{secrets.NPM_TOKEN_STORAGE_TYPES}}
NPM_TOKEN_UTIL: ${{secrets.NPM_TOKEN_UTIL}}
NPM_TOKEN_VERTEXAI_PREVIEW: ${{secrets.NPM_TOKEN_VERTEXAI_PREVIEW}}
NPM_TOKEN_VERTEXAI: ${{secrets.NPM_TOKEN_VERTEXAI}}
NPM_TOKEN_WEBCHANNEL_WRAPPER: ${{secrets.NPM_TOKEN_WEBCHANNEL_WRAPPER}}
NPM_TOKEN_FIREBASE: ${{secrets.NPM_TOKEN_FIREBASE}}
NPM_TOKEN_APP_COMPAT: ${{ secrets.NPM_TOKEN_APP_COMPAT }}
4 changes: 2 additions & 2 deletions .github/workflows/release-staging.yml
Original file line number Diff line number Diff line change
@@ -49,7 +49,7 @@ jobs:
- name: Set up node (20)
uses: actions/setup-node@v3
with:
node-version: 20.x
node-version: 22.10.0
- name: Merge main into release
uses: actions/github-script@v6
with:
@@ -110,7 +110,7 @@ jobs:
NPM_TOKEN_STORAGE: ${{secrets.NPM_TOKEN_STORAGE}}
NPM_TOKEN_STORAGE_TYPES: ${{secrets.NPM_TOKEN_STORAGE_TYPES}}
NPM_TOKEN_UTIL: ${{secrets.NPM_TOKEN_UTIL}}
NPM_TOKEN_VERTEXAI_PREVIEW: ${{secrets.NPM_TOKEN_VERTEXAI_PREVIEW}}
NPM_TOKEN_VERTEXAI: ${{secrets.NPM_TOKEN_VERTEXAI}}
NPM_TOKEN_WEBCHANNEL_WRAPPER: ${{secrets.NPM_TOKEN_WEBCHANNEL_WRAPPER}}
NPM_TOKEN_FIREBASE: ${{secrets.NPM_TOKEN_FIREBASE}}
NPM_TOKEN_APP_COMPAT: ${{ secrets.NPM_TOKEN_APP_COMPAT }}
2 changes: 1 addition & 1 deletion .github/workflows/release-tweet.yml
Original file line number Diff line number Diff line change
@@ -37,7 +37,7 @@ jobs:
- name: Setup Node.js 20.x
uses: actions/setup-node@master
with:
node-version: 20.x
node-version: 22.10.0
- name: Poll release notes page on devsite
run: node scripts/ci/poll_release_notes.js
env:
10 changes: 5 additions & 5 deletions .github/workflows/test-all.yml
Original file line number Diff line number Diff line change
@@ -43,7 +43,7 @@ jobs:
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 20.x
node-version: 22.10.0
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
@@ -82,7 +82,7 @@ jobs:
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 20.x
node-version: 22.10.0
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
@@ -133,7 +133,7 @@ jobs:
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 20.x
node-version: 22.10.0
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
@@ -173,7 +173,7 @@ jobs:
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 20.x
node-version: 22.10.0
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
@@ -217,7 +217,7 @@ jobs:
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 20.x
node-version: 22.10.0
- run: cp config/ci.config.json config/project.json
- run: yarn
- run: yarn build:${{ matrix.persistence }}
29 changes: 27 additions & 2 deletions .github/workflows/test-changed-auth.yml
Original file line number Diff line number Diff line change
@@ -59,7 +59,7 @@ jobs:
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 20.x
node-version: 22.10.0
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
@@ -91,7 +91,7 @@ jobs:
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 20.x
node-version: 22.10.0
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
@@ -102,3 +102,28 @@ jobs:
run: xvfb-run yarn test:changed auth
env:
BROWSERS: 'Firefox'

test-webkit:
name: Test Auth on Webkit if Changed
runs-on: macos-latest

steps:
- name: Checkout Repo
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 22.10.0
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
yarn
npx playwright install webkit
- name: build
run: yarn build:changed auth
- name: Run tests on changed packages
run: yarn test:changed auth
env:
BROWSERS: 'WebkitHeadless'
2 changes: 1 addition & 1 deletion .github/workflows/test-changed-fcm-integration.yml
Original file line number Diff line number Diff line change
@@ -41,7 +41,7 @@ jobs:
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
node-version: 20.x
node-version: 22.10.0
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
Loading
Oops, something went wrong.
You are viewing a condensed version of this merge commit. You can view the full changes here.