failed initial V2 function deploy leaves it in wrong type of trigger state

[brantgurga]

[REQUIRED] Environment info

firebase-tools: 13.31.2

Platform: Ubuntu-based

[REQUIRED] Test case

Deploy a NEW V2 background function in Node that references something in a parent directory's node_modules.

[REQUIRED] Steps to reproduce

Deploy function. Allow it to fail. Fix or remove bad reference. Deploy function again.

[REQUIRED] Expected behavior

Second deploy will succeed.

[REQUIRED] Actual behavior

First deploy fails during deploy because the container build can't reference the package in a parent directory's node_modules. This is expected. When this is fixed and deploy attempted again, you find that firebase-tools left the function that failed to build as http triggered which blocks updating it. If it fails, it should clean up what it did so that you're in a state to deploy the fixed version.

[colerogers]

Hi @brantgurga thanks for open this issue. I'm able to reproduce this behavior on my end. From what I can tell, this behavior has always occurred and isn't a regression (anyone can chime if this is not the case). I'm going to mark this as a feature request, since I believe we're currently following what the gcloud command does. We'll try to prioritize this work internally. However, if anyone from the community wants to open a PR, we'd be happy to help on the reviews. Thanks!