Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go/ai): error if multiple tool requests share Ref #2283

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kwjw
Copy link
Contributor

@kwjw kwjw commented Mar 10, 2025

Resolves #2224.

If the same tool is called multiple times in the same request, then the tool requests must have distinct Ref values.

Checklist (if applicable):

@kwjw kwjw requested a review from apascal07 March 10, 2025 21:19
@github-actions github-actions bot added the go label Mar 10, 2025
Copy link
Collaborator

@apascal07 apascal07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one way to solve this but any model-generated refs aren't significant, we can just fill them in ourselves with an index or similar if they're not filled in by the model.

@pavelgj
Copy link
Collaborator

pavelgj commented Mar 11, 2025

This is one way to solve this but any model-generated refs aren't significant, we can just fill them in ourselves with an index or similar if they're not filled in by the model.

Can use #2250 for reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Go] Multiple tool calls should be using the ref field to disambiguate
3 participants