feat: add JSON lint check for i18n folder #21687
Open
+24
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Davut Kilic <davut2003@hotmail.de>
davutkilic
force-pushed
the
feature/json-lint-check
branch
from
16da18d to
91e11a1
Compare
reasonerjt
reviewed
Mar 4, 2025
.github/workflows/json-lint.yml
Outdated
| - name: Run JSON lint | ||
| run: | | ||
| # Alle JSON-Dateien im i18n-Ordner suchen |
There was a problem hiding this comment.
Could you write the comment in English?
Signed-off-by: Davut Kilic davut2003@hotmail.de Signed-off-by: Davut Kilic <davut2003@hotmail.de>
davutkilic
force-pushed
the
feature/json-lint-check
branch
from
9bf55a8 to
1bb871b
Compare
|
Translated it into English |
bupd
suggested changes
Mar 4, 2025
bupd
suggested changes
Mar 4, 2025
There was a problem hiding this comment.
Please add the below to the .eslintrc.json
{
"files": ["*.html"],
"excludedFiles": ["*inline-template-*.component.html"],
"extends": ["plugin:prettier/recommended"],
"rules": {
"prettier/prettier": ["error", { "parser": "angular" }]
}
},
+ {
+ "files": ["*.json"],
+ "extends": [
+ "plugin:json/recommended-legacy",
+ "plugin:prettier/recommended"
+ ],
+ "rules": {
+ "json/*": ["error"],
+ "prettier/prettier": ["error", { "parser": "angular" }]
+ }
+ }Hope this helps
|
Also don't forget: Thanks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21687 +/- ##
==========================================
+ Coverage 45.36% 46.24% +0.87%
==========================================
Files 244 250 +6
Lines 13333 14133 +800
Branches 2719 2908 +189
==========================================
+ Hits 6049 6536 +487
- Misses 6983 7250 +267
- Partials 301 347 +46
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comprehensive Summary of your change
Added a new GitHub Actions workflow (json-lint.yml) to validate all JSON files in src/portal/src/i18n/.
This ensures any malformed JSON will cause the CI to fail, preventing invalid translations from being merged.
Issue being fixed
Fixes #21685
Checklist
Well Written Title and Summary of the PR
Example: “feat: add JSON lint check for i18n folder”
Label the PR as needed
Choose an appropriate label such as release-note/new-feature or release-note/enhancement.
Accepted the DCO
Make sure all your commits include the Signed-off-by: Your Name you@example.com line.
Tests are passing and test coverage is added if needed
The JSON lint check is run in the new workflow.
Docs impact
No separate docs change needed, since this is an internal CI improvement.