Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section 1.1 example code should check for true, not false #26

Open
BruceWilliams opened this issue Aug 17, 2019 · 2 comments
Open

Section 1.1 example code should check for true, not false #26

BruceWilliams opened this issue Aug 17, 2019 · 2 comments

Comments

@BruceWilliams
Copy link

The second example in section 1.1 says:

expect(result.approved).to.be.false;

It should be:

expect(result.approved).to.be.true;

(I'm guessing you made it false so you could simulate the error output in the next picture.)

@baruchvlz
Copy link

baruchvlz commented Aug 18, 2019

Considering the write put this warning:

A deployment just failed, a test named “Add product” failed. Does this tell you what exactly is malfunctioning?

I doubt this is an error. The writer is trying to demonstrate the use of good test names and how helpful it is to have them when a test fails.

@goldbergyoni
Copy link
Owner

@BruceWilliams @baruchvlz Welcome 🎈

I think this is indeed a mistake, and as @baruchvlz said it does not make a lot of difference as the example focused on the name of the test. I'm leaving this issue open until I'll fix it

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants