cdktf: upgraded packages and now logical ids are different

[kevanslumin]

Expected Behavior

I made the following Go module updates below and now my logical ids are different. They seem to be missing the hash at the end and also hyphens are not converted to underscores any longer. I'm having trouble figuring out what changed, and would appreciate it if anyone can shed some light.

-       github.com/aws/constructs-go/constructs/v10 v10.1.225
+       github.com/aws/constructs-go/constructs/v10 v10.4.2
-       github.com/aws/jsii-runtime-go v1.73.0
+       github.com/aws/jsii-runtime-go v1.109.0
-       github.com/cdktf/cdktf-provider-aws-go/aws/v12 v12.0.1
+       github.com/cdktf/cdktf-provider-aws-go/aws/v19 v19.56.1
-       github.com/hashicorp/terraform-cdk-go/cdktf v0.15.0
+       github.com/hashicorp/terraform-cdk-go/cdktf v0.20.11

Here is an example:

stack Id: example-stack

vpn connection id: cdktf-example-vpn

original logical id: examplestack_cdktfexamplevpn_F638B234

new logical id: cdktf-example-vpn

Actual Behavior

Here is an example:

stack Id: example-stack

vpn connection id: cdktf-example-vpn

original logical id: examplestack_cdktfexamplevpn_F638B234

new logical id: cdktf-example-vpn

Steps to Reproduce

Use the same versions as shown above, I think. There were other packages updated, but I'm having trouble pinpointing the bad one because several need to be updated together.

Versions

-       github.com/aws/constructs-go/constructs/v10 v10.1.225
+       github.com/aws/constructs-go/constructs/v10 v10.4.2
-       github.com/aws/jsii-runtime-go v1.73.0
+       github.com/aws/jsii-runtime-go v1.109.0
-       github.com/cdktf/cdktf-provider-aws-go/aws/v12 v12.0.1
+       github.com/cdktf/cdktf-provider-aws-go/aws/v19 v19.56.1
-       github.com/hashicorp/terraform-cdk-go/cdktf v0.15.0
+       github.com/hashicorp/terraform-cdk-go/cdktf v0.20.11

Providers

New:

Providers required by configuration:
.
└── provider[registry.terraform.io/hashicorp/aws] 5.65.0

Providers required by state:

provider[registry.terraform.io/hashicorp/aws]

Old:

Providers required by configuration:
.
└── provider[registry.terraform.io/hashicorp/aws] 4.51.0

Providers required by state:

provider[registry.terraform.io/hashicorp/aws]

Gist

No response

Possible Solutions

No response

Workarounds

No response

Anything Else?

No response

References

No response

Help Wanted

• I'm interested in contributing a fix myself

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[kevanslumin]

Okay, after more testing I narrowed down the set of changes that start exhibiting the new behavior:

New behavior:

+	github.com/aws/constructs-go/constructs/v10 v10.2.52
+	github.com/aws/jsii-runtime-go v1.84.0
+	github.com/cdktf/cdktf-provider-aws-go/aws/v15 v15.0.0
+	github.com/hashicorp/terraform-cdk-go/cdktf v0.17.0

Old behavior:

+	github.com/aws/constructs-go/constructs/v10 v10.2.17
+	github.com/aws/jsii-runtime-go v1.80.0
+	github.com/cdktf/cdktf-provider-aws-go/aws/v14 v14.0.4
+	github.com/hashicorp/terraform-cdk-go/cdktf v0.16.1