Improve GitHub Actions hazelcast membership check
#1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We restrict actions' execution to members of the `hazelcast` organisation using `hazelcast/hazelcast-tpm/membership`, passing in the user derviced from `github.event.pull_request.head.repo.owner.login`. This is the owner of the repository, _not_ the user itself. In the case of a non-fork PR - i.e. one in the `hazelcast` original repo - the `owner` will be `hazelcast` (which _isn't_ a GitHub user, and _isn't_ a member of the `hazelcast` organisation) and will fail. This nuance prevented hazelcast/hazelcast-python-client#720 from being merged. Instead we should query `github.actor` as [already used in the C++ client](https://github.com/hazelcast/hazelcast-cpp-client/blame/b63e40748aa8e06f790510d86e1eae87cc36925a/.github/workflows/build-pr.yml#L50).
|
@ihsandemir are you able to review, please? |
bump :) |
@ihsandemir just a reminder on this one :) |
ihsandemir
reviewed
Mar 24, 2025
https://github.com/hazelcast/hazelcast-nodejs-client/actions/runs/14047006191/job/39329912784 EDIT - The action overall fails, but the |
ihsandemir
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We restrict actions' execution to members of the
hazelcastorganisation usinghazelcast/hazelcast-tpm/membership, passing in the user derviced fromgithub.event.pull_request.head.repo.owner.login.This is the owner of the repository, not the user itself.
In the case of a non-fork PR - i.e. one in the
hazelcastoriginal repo - theownerwill behazelcast(which isn't a GitHub user, and isn't a member of thehazelcastorganisation) and will fail.This nuance prevented hazelcast/hazelcast-python-client#720 from being merged.
Instead we should query
github.actoras already used in the C++ client.