Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsDoc is not an editor command for filetype=javascriptreact/typescriptreact #116

Closed
matt-savvy opened this issue Oct 6, 2021 · 4 comments · Fixed by #117
Closed

JsDoc is not an editor command for filetype=javascriptreact/typescriptreact #116

matt-savvy opened this issue Oct 6, 2021 · 4 comments · Fixed by #117
Labels
bug

Comments

@matt-savvy
Copy link

Hello,

I get error E492 Not an editor command: JsDoc for jsx and tsx files. I was able to fix this for jsx only by tweaking my vimrc to use 'javascriptreact' instead of 'javascript.jsx' like so:

Plug 'heavenshell/vim-jsdoc', {
  \ 'for': ['javascript', 'javascriptreact', 'typescript'],
  \ 'do': 'make install'
\}

But adding 'typescriptreact' doesn't seem to work for tsx.
@heavenshell
Copy link
Owner

@matt-savvy

Thank you for reporting.
I'm bit a busy now, so please wait a moment 🙏
This weekend, I'll investigate this.

BTW are you using vim-plug?

@heavenshell heavenshell added the bug label Oct 6, 2021
@matt-savvy
Copy link
Author

No worries, take your time. Thanks for the quick response.

Yes, using vim-plug.

@heavenshell heavenshell mentioned this issue Oct 9, 2021
Merged
@heavenshell
Copy link
Owner

@matt-savvy Fixed and released as 2.2.0
Please check.

Thank you for reporting!

@matt-savvy
Copy link
Author

@heavenshell Yup, can confirm that I'm not getting that error anymore.

Happy to help, thanks for the quick solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add typescriptreact and javascriptreact to ftplugin heavenshell/vim-jsdoc
2 participants
@heavenshell @matt-savvy