Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TF Implementation of BEiT #18085

Open
MadElf1337 opened this issue Jul 10, 2022 · 6 comments
Open

Adding TF Implementation of BEiT #18085

MadElf1337 opened this issue Jul 10, 2022 · 6 comments
Labels
WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress

Comments

@MadElf1337
Copy link

Feature request

Addition of TF implementation of BEiT

Motivation

I have always seen that there is a discrepancy in the availability of models for PyTorch and the models available in TensorFlow, and want to have models for usage in both backends.

Your contribution

I will add the implementation of BEiT in TF :)

cc - @gante

@LysandreJik
Copy link
Member

cc @NielsRogge @amyeroberts

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@amyeroberts
Copy link
Collaborator

Hi @MadElf1337 do you have any updates? Are you still planning on contributing this model?

@MadElf1337
Copy link
Author

MadElf1337 commented Aug 9, 2022

Yep I’m still working on the model, had to keep it aside for a bit due to my uni exam schedule, but will start again the day my exams are over

Regarding the updates, I am done with the architecture, have to write the functions for specific purposes(like segmentation) and the tests

@amyeroberts
Copy link
Collaborator

Great - glad to hear you're still interested :)

As @NielsRogge pointed out, data2vec vision is an extension of BEiT. This means the porting should be a lot simpler! In our pytorch BEiT implementation, you can see this from the #Copied from statements. Ideally the TF implementation would reflect this and be the same as our pytorch implementation, however TF data2vec vision is already implemented. So, we need to move the data2vec code to beit, and then add the necessary #Copied from statement in data2vec. Does this make sense?

Could you open a draft PR for the model please so that the code is visible?

Good luck with the last of your exams!

@MadElf1337
Copy link
Author

Yes I’ll open a draft PR to show the code that’s been done till date

And thanks!

@huggingface huggingface deleted a comment from github-actions bot Sep 5, 2022
@LysandreJik LysandreJik added the WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress label Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants