Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Clarify is_decoder usage in PretrainedConfig documentation #36724

Merged
merged 4 commits into from
Mar 17, 2025

Conversation

d-kleine
Copy link
Contributor

What does this PR do?

Enhance the documentation for the is_decoder parameter to specify its relevance to encoder/decoder architectures and clarify its impact on different model types.

Fixes #36482

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@stevhliu @Rocketknight1

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@d-kleine d-kleine marked this pull request as ready for review March 14, 2025 14:17
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

d-kleine and others added 2 commits March 14, 2025 18:26

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
updated doc

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@stevhliu
Copy link
Member

Hey @shethaadit, would you mind stop adding reviews without any substantial feedback to PRs please? Thanks! 🤗

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu merged commit cbfb8d7 into huggingface:main Mar 17, 2025
10 checks passed
@d-kleine d-kleine deleted the docs_isdecoder branch March 17, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading documentation for is_decoder configuration parameter
4 participants