Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On MoE implementation in HuggingFace #36730

Closed
Neo9061 opened this issue Mar 14, 2025 · 2 comments
Closed

On MoE implementation in HuggingFace #36730

Neo9061 opened this issue Mar 14, 2025 · 2 comments

Comments

@Neo9061
Copy link

Neo9061 commented Mar 14, 2025

On the Mixtral MoE implementation, I saw it mentioned that it is equivalent to standard MoE with full capacity (no dropped tokens). I just wonder where the token dropless logic is implemented?

Code reference: https://github.com/huggingface/transformers/blob/2c2495cc7b0e3e2942a9310f61548f40a2bc8425/src/transformers/models/mixtral/modeling_mixtral.py#L89C28-L90C20

CC @ArthurZucker if you have any insights. Thank you!

@ArthurZucker
Copy link
Collaborator

Hey! The doc is probably a bit outdated / was I think copy pasted from original code!
But basically as you can see on the code, there is no capacity and there is no dropout, so all tokens get assign to an expert.

@ArthurZucker
Copy link
Collaborator

I'll close this as it's not a bug but we can keep the conversation 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants