Fix chameleon's TypeError because inputs_embeds may None #36673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the |
qubvel
reviewed
Mar 12, 2025
Comment on lines
1295
to
1299
| if ( | ||
| not is_torchdynamo_compiling() | ||
| and inputs_embeds is not None | ||
| and inputs_embeds[special_image_mask].numel() != image_tokens.numel() | ||
| ): |
There was a problem hiding this comment.
Should we move the following block above instead of adding this check? I suppose @zucchini-nlp knows better 😄
if inputs_embeds is None:
inputs_embeds = self.embed_tokens(input_ids)
|
cool, let's merge then! |
This was referenced Mar 20, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When training Chameleon, I got the error message: "TypeError 'nonetype' object is not subscriptable". Because
inputs_embedsmay be None, I think it should checkinputs_embedstype first before using it.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@amyeroberts, @qubvel, @zucchini-nlp
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.