Support loading custom models (trust_remote_code=True
) in offline mode from local
#36808
+164
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #34855
And should fix UKPLab/sentence-transformers#2613 (will close separately)
trust_remote_code=True
) can be fully saved withsave_pretrained()
and able to be loaded withfrom_pretrained()
in offline modesave_pretrained()
. And during loading withfrom_pretrained()
in offline mode (even on a new fresh machine) it won't try to reach out to HF hub since all files will be self-contained in local dirBefore submitting
to it if that's the case.
Offline mode doesn't work with models that require
trust_remote_code=True
#34855 (comment)documentation guidelines, and here are tips on formatting docstrings.
No need to update the docs IMHO, since it adds expected behavior according to current docs
Who can review?
@Rocketknight1
@ArthurZucker