Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemma3 fp16 fix #36831

Closed
wants to merge 8 commits into from
Closed

Gemma3 fp16 fix #36831

wants to merge 8 commits into from

Conversation

mobicham
Copy link
Contributor

What does this PR do?

Fixes float16 inference with Gemma 3 models: simply clip the input in Gemma3RMSNorm

Fixes #36822

Who can review?

@ArthurZucker @Rocketknight1

@github-actions github-actions bot marked this pull request as draft March 19, 2025 16:36
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

@mobicham mobicham closed this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gemma 3 is broken with fp16
1 participant