Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set weights_only in torch.load #36991

Merged
merged 3 commits into from
Mar 27, 2025
Merged

Set weights_only in torch.load #36991

merged 3 commits into from
Mar 27, 2025

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Mar 26, 2025

Apply TorchFix to enhance torch.load

@github-actions github-actions bot marked this pull request as draft March 26, 2025 06:30
@github-actions GitHub Actions
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@cyyever cyyever force-pushed the weight_only_load branch 4 times, most recently from 7e8f13d to 7949063 Compare March 26, 2025 06:43
@cyyever cyyever marked this pull request as ready for review March 26, 2025 06:44
@github-actions github-actions bot requested review from muellerzr and SunMarc March 26, 2025 06:44
@cyyever cyyever force-pushed the weight_only_load branch 3 times, most recently from ad3c67c to 7631c71 Compare March 26, 2025 06:53
Rocketknight1
Rocketknight1 approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, LGTM! We're doing some significant work on the CI right now, but try rebasing in a few hours and hopefully things should be green at that point.

muellerzr
muellerzr approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this was introduced in 2.0 which is within our minimums so lg2m as well

@cyyever
Copy link
Contributor Author

cyyever commented Mar 27, 2025

And PT 2.6.0 defaults weights_only to True.

SunMarc
SunMarc approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG

@Rocketknight1 Rocketknight1 merged commit 41a0e58 into huggingface:main Mar 27, 2025
18 checks passed
@cyyever cyyever deleted the weight_only_load branch March 28, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muellerzr muellerzr

@Rocketknight1 Rocketknight1

@SunMarc SunMarc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cyyever @muellerzr @Rocketknight1 @SunMarc