Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing for None valued variables #37004

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Mar 26, 2025

Add Optional for more None valued variables.

@github-actions github-actions bot marked this pull request as draft March 26, 2025 14:54
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@cyyever cyyever force-pushed the optional3 branch 3 times, most recently from e232c31 to 7b34528 Compare March 26, 2025 15:26
@cyyever cyyever marked this pull request as ready for review March 26, 2025 15:28
@cyyever cyyever changed the title Fix typing for None-able variables Fix typing for None valued variables Mar 26, 2025
Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, LGTM!

@Rocketknight1 Rocketknight1 merged commit de77f5b into huggingface:main Mar 27, 2025
18 checks passed
@cyyever cyyever deleted the optional3 branch March 27, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants