Add Fast Chinese-CLIP Processor #37012
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
yonigozlan
reviewed
Mar 26, 2025
There was a problem hiding this comment.
Looks great @keetrap , thanks for working on this! Only one test left to adapt, and if all the tests pass with RUN_SLOW=1 python -m pytest tests/models/chinese_clip/test_image_processing_chinese_clip.py, it should be ready to merge!
tests/models/chinese_clip/test_image_processing_chinese_clip.py
Outdated
Show resolved
Hide resolved
69 tasks
|
@yonigozlan Thanks for the review. Tests Updated. |
|
@keetrap Great LGTM! could you update your branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #36978
cc @qubvel @yonigozlan