Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid building all architectures when in merge queue #6880

Closed
yurishkuro opened this issue Mar 19, 2025 · 0 comments · Fixed by #6882
Closed

Avoid building all architectures when in merge queue #6880

yurishkuro opened this issue Mar 19, 2025 · 0 comments · Fixed by #6882
Labels
docker Pull requests that update Docker code good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

I noticed that when the PR is in the merge queue the all-in-one workflows run for almost 20min while all others finish in 5-6min. From the logs it can be seen that we're building all architectures, which is unnecessary for a merge, but the build-binaries step still succeeds faster because it parallelizes all architectures while all-in-one builds them sequentially.

The quick fix is to change .github/workflows/ci-docker-all-in-one.yml to not build all arch on PRs and merge queue events (currently only PRs are excluded).

Longer term fix is maybe to parallelize the different arch builds similar to how build-binaries is done.
@yurishkuro yurishkuro added good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement labels Mar 19, 2025
@dosubot dosubot bot added the docker Pull requests that update Docker code label Mar 19, 2025
sAchin-680 added a commit to sAchin-680/jaeger that referenced this issue Mar 19, 2025
@sAchin-680
Optimize CI: Avoid multi-arch builds in merge queue (jaegertracing#6880)
54f60aa 
Signed-off-by: sAchin-680 <mrmister680@gmail.com>
@sAchin-680 sAchin-680 mentioned this issue Mar 19, 2025
Closed
4 tasks
sAchin-680 added a commit to sAchin-680/jaeger that referenced this issue Mar 19, 2025
@sAchin-680
Optimize CI: Avoid multi-arch builds in merge queue (jaegertracing#6880)
bdfb4bf 
Signed-off-by: sAchin-680 <mrmister680@gmail.com>
@sAchin-680 sAchin-680 mentioned this issue Mar 19, 2025
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Mar 19, 2025
@sAchin-680
[all-in-one] Avoid multi-arch builds in merge queue (#6880) (#6882)
13111cb 
## Which problem is this PR solving?
- Resolves #6880: Optimizes the all-in-one CI workflow by preventing
unnecessary multi-architecture builds in the merge queue, reducing build
times.

## Description of the changes
- Updated `.github/workflows/ci-docker-all-in-one.yml` to exclude
multi-arch builds for merge queue events, similar to PR handling.
- This prevents sequential multi-arch builds, significantly improving CI
efficiency.

## How was this change tested?


## Checklist
- [ ] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [ ] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

Signed-off-by: sAchin-680 <mrmister680@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docker Pull requests that update Docker code good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
1 participant
@yurishkuro