Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Controller-Runtime Dependencies from API Types #564

Closed
robscott opened this issue Mar 24, 2025 · 1 comment · Fixed by #565
Closed

Remove Controller-Runtime Dependencies from API Types #564

robscott opened this issue Mar 24, 2025 · 1 comment · Fixed by #565
Assignees
@kfswain
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@robscott
Copy link
Member

robscott commented Mar 24, 2025 •
edited
Loading

What happened:
Our API types currently include controller-runtime dependencies.

What you expected to happen:
We should not have a dependency on Controller-Runtime in our API types. For example, look at the equivalent Gateway API file that is fully generated: https://github.com/kubernetes-sigs/gateway-api/blob/aa9679341fdc2cd919a230bf9887416c1881ef2f/apis/v1/zz_generated.register.go#L24-L43

/assign @kfswain
/cc @LiorLieberman
@robscott robscott added the kind/bug Categorizes issue or PR as related to a bug. label Mar 24, 2025
@LiorLieberman
Copy link
Member

/cc @howardjohn

@kfswain kfswain mentioned this issue Mar 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kfswain kfswain

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove controller-runtime dependency from API kfswain/llm-instance-gateway
3 participants
@robscott @LiorLieberman @kfswain