Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bodyless requests to passthrough EPP #555

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

kfswain
Copy link
Collaborator

@kfswain kfswain commented Mar 20, 2025

This PR allows requests that do not have a body or trailer to passthrough to a random endpoint. This operates under the assumption that bodyless messages will be GET requests for administrative endpoints (such as /health or /v1/models).

Enforcement will involve a something like: #526
EPP path restrictions are still in progress

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and liu-cong March 20, 2025 22:06
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2025
Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit e137751
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67ddf43bc1332500079ded70
😎 Deploy Preview https://deploy-preview-555--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kfswain kfswain force-pushed the streaming-refactor branch 3 times, most recently from 429d424 to ea17f5f Compare March 21, 2025 18:41
@kfswain kfswain force-pushed the streaming-refactor branch from ea17f5f to b6890c6 Compare March 21, 2025 18:41
@kfswain kfswain changed the title [WIP] Allow bodyless requests to passthrough EPP Allow bodyless requests to passthrough EPP Mar 21, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2025
@kfswain kfswain force-pushed the streaming-refactor branch 2 times, most recently from 8cfe836 to dd5d6bf Compare March 21, 2025 19:07
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 21, 2025
@kfswain kfswain force-pushed the streaming-refactor branch from dd5d6bf to 3513345 Compare March 21, 2025 19:22
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 21, 2025
@kfswain kfswain force-pushed the streaming-refactor branch from 3513345 to ee6bce5 Compare March 21, 2025 19:33
@kfswain kfswain force-pushed the streaming-refactor branch from ee6bce5 to 2e2aab8 Compare March 21, 2025 21:34
@ahg-g
Copy link
Contributor

ahg-g commented Mar 21, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2025
@kfswain kfswain force-pushed the streaming-refactor branch from 2e2aab8 to 18f236b Compare March 21, 2025 23:15
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2025
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 21, 2025
@kfswain kfswain force-pushed the streaming-refactor branch from 18f236b to e137751 Compare March 21, 2025 23:20
@ahg-g
Copy link
Contributor

ahg-g commented Mar 21, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit 12bcc9a into kubernetes-sigs:main Mar 21, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants