Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAS: add test cases for multiple podsets to TestFindTopologyAssignment #4549

Open
mimowo opened this issue Mar 11, 2025 · 2 comments · May be fixed by #4710
Open

TAS: add test cases for multiple podsets to TestFindTopologyAssignment #4549

mimowo opened this issue Mar 11, 2025 · 2 comments · May be fixed by #4710
Assignees
@Horiodino
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@mimowo
Copy link
Contributor

mimowo commented Mar 11, 2025 •
edited
Loading

What would you like to be cleaned:

Extend the tests in TestFindTopologyAssignment (in pkg/cache/tas_cache_test.go) with multiple pod sets.

Why is this needed:

To cover full logic of the exposed function FindTopologyAssignment at this level of tests. The case of multiple podsets is currently covered by scheduler_test.go, but it is a higher level test.

This was discussed in the thread: #4200 (comment)
@mimowo mimowo added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 11, 2025
@mimowo
Copy link
Contributor Author

mimowo commented Mar 11, 2025

cc @tenzen-y @PBundyra

@Horiodino
Copy link
Contributor

/assign

@Horiodino Horiodino linked a pull request Mar 20, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Horiodino Horiodino

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test cases for multiple podsets Horiodino/kueue
2 participants
@mimowo @Horiodino