-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce external secret refresh capability #90
base: main
Are you sure you want to change the base?
feat: introduce external secret refresh capability #90
Conversation
Adds new RefreshInterval field to SecretSync CRD allowing periodic polling of external secrets from providers (like Azure Key Vault). This enables automatic detection of secret changes in external providers without manual intervention. Signed-off-by: Marcelo Cyreno <812725+marcelocyreno@users.noreply.github.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: marcelocyreno The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @marcelocyreno! |
Hi @marcelocyreno. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/hold The sync controller isn't allowed to gain any capabilities that the driver doesn't have. The driver only has a global resync interval, and the controller is expected to have that and nothing more. |
Implements exponential backoff using workqueue for failed reconciliations. Signed-off-by: Marcelo Cyreno <812725+marcelocyreno@users.noreply.github.com>
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR introduces periodic polling capability for external secrets by adding a new
RefreshInterval
field to SecretSync CRD. Currently, the SecretSync controller only updates secrets when the SecretSync object changes. This enhancement allows the controller to periodically check for changes in external secret providers (like Azure Key Vault) and automatically update the Kubernetes secrets when the external source changes.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #83
Special notes for your reviewer:
RefreshInterval
field to SecretSync CRDTODOs: